Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-403

OrderService.getOrders does not correctly use ORDER_STATUS

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Should
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: OpenMRS 1.9.0
    • Component/s: None
    • Labels:
    • Complexity:
      Low

      Description

      The service method OrderService.getOrders() takes in an optional ORDER_STATUS parameter. This is correctly used to filter voided and non-voided Orders within HibernateOrderDAO, but the code is missing from either the DAO or the ServiceImpl to filter orders by either CURRENT or COMPLETE status.

      A call to the getOrders() method with either ORDER_STATUS.CURRENT or ORDER_STATUS.COMPLETE incorrectly returns all non-voided orders.

        Attachments

        1. OrderService.patch
          4 kB
        2. OrderStatus.patch
          8 kB

          Issue Links

            Activity

              People

              Assignee:
              bwolfe Ben Wolfe
              Reporter:
              mseaton Mike Seaton
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: