Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-276

personField.tag breaks if pageContext contains a 'roles' variable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Non-Essential
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: OpenMRS 1.9.0
    • Component/s: None
    • Complexity:
      Low

      Description

      personField.tag contains

      <div dojoType="PersonSearch" ... roles="$\{roles\}" ...
      
      • The small problem with this is that it assumes roles is a comma-separated String, rather than a List<Role>.
      • The bigger problem is that this isn't documented anywhere, so if I have 'roles' in my model map and I include this tag, the search breaks.

      It may be sufficient to add this to the top. I don't know if that will shadow and hide the 'roles' variable from outside if it isn't specified in the actual tag call

      <%@ attribute name="roles" required="false" %>
      

        Attachments

          Activity

            People

            • Assignee:
              bwolfe Ben Wolfe
              Reporter:
              darius Darius Jazayeri
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: