Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-2433

AdministrationService.saveGlobalProperties is dangerous, and should be changed

    Details

    • Complexity:
      Low

      Description

      The AdministrationService.saveGlobalProperties(List<GlobalProperty>) method does not do what you would expect. Actually it wipes out all other global properties besides the ones you pass in. This frequently leads to errors, and it's only used "correctly" in one place in core. (That's Manage Global Properties controller.)

      Proposed solution:

      • Change the behavior of saveGlobalProperties(List) to actually just save the specified global properties without deleting anything.
      • Put the iterate-over-all-GPs-and-purge behavior in the controller for Manage Global Properties, instead of where it currently lives in AdministrationServiceImpl.saveGlobalProperties.

      Backport this to 1.6.x, 1.7.x, and 1.8.x

        Gliffy Diagrams

          Attachments

            Attachments-Category-Modification

              Activity

                People

                • Assignee:
                  raff Rafal Korytkowski
                  Reporter:
                  darius Darius Jazayeri
                  Watchers:
                  Ben Wolfe, Darius Jazayeri, Rafal Korytkowski, Wyclif Luyima
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 4 hours, 7 minutes
                    4h 7m