Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-231

HibernateContextDAO.openSession/closeSession

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Could
    • Resolution: Incomplete
    • Affects Version/s: None
    • Fix Version/s: OpenMRS 1.9.0
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Medium

      Description

      I took a quick look at the impl of HibernateContextDAO.openSession/closeSession and I think there's a bug or two:

      1. HibernateContextDAO has a member variable "participate", however, the HibernateContextDAO instance is shared across threads.
      2. The implementation in the code suggests that it should be ok call openSession/closeSession many times allowing smaller units of work to be joined to participate in a larger unit. The impl needs track the number of calls to open/close so it can clear the bindings at the correct time.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            mharrison Marc Harrison [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: