Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-2111

Short names for concepts should be allowed to duplicate full-length names within a locale

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Should
    • Resolution: Fixed
    • Affects Version/s: OpenMRS 1.7.1
    • Fix Version/s: OpenMRS 1.7.3, OpenMRS 1.8.1
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Low

      Description

      This error was discovered while upgrading the MVP concept dictionary to 1.8.

      For example the concept for CD4 count might have the following names in the English locale:

      • "CD4 count, by FACS" (type=fully-specified)
      • "CD4" (type=synonym)
      • "CD4" (type=short)

      ConceptValidator will currently reject this, but it should actually be allowed. (Short names should be ignored when checking that there are no duplicate names in a locale.)

      – Burke said this in more detail on the dev list: –

      "short name" was intended specifically to provide an abbreviated term for space-constrained uses (reports, spreadsheets, etc.) and not as a synonym. While the abbreviation may be a valid synonym in many cases, I'm not sure we could count on it being a valid synonym in all cases. Certain ambiguities may be tolerated for the sake of brevity (in a short name for a spreadsheet), but not be desirable for searching.

      So, I would favor that short names not be treated as another synonym - i.e., ignore short name when checking for case-insensitive uniqueness among canonical name, synonyms, and lookup terms for a concept within a single locale.

        Attachments

        1. ConceptValidatorPatch
          5 kB
        2. ConceptValidatorPatch2
          4 kB
        3. ConceptValidatorPatch3
          4 kB

          Activity

            People

            • Assignee:
              corey.sobel@gmail.com Corey Sobel [X] (Inactive)
              Reporter:
              darius Darius Jazayeri
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: