Uploaded image for project: 'OpenMRS Core'
  1. OpenMRS Core
  2. TRUNK-1654

getGroupMembers() returns voided obs

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Could
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: OpenMRS 1.9.0
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Low

      Description

      The obs.getGroupMembers() method returns both voided and non-voided obs. Do we want to change this method to only return non-voided obs, and potentially create a obs.getAllGroupMembers() method that returns both voided and non-voided obs?

      If we do so, we will need to modify obs.hbm.xml since hibernate uses obs.getGroupMembers() in it's mapping.

      We'd also need to decide how we'd want isObsGrouping() and hasGroupMembers() to work.

      Alternatively, if we keep things as is, we should update the comments to note that getGroupMembers() returned both voided an non-voided obs.

        Gliffy Diagrams

          Attachments

          1. ObsPatch2.txt
            10 kB
          2. ObsPatch3.txt
            11 kB
          3. patch.txt
            10 kB

            Attachments-Category-Modification

              Activity

                People

                • Assignee:
                  corey.sobel@gmail.com Corey Sobel
                  Reporter:
                  mogoodrich Mark Goodrich
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: