Uploaded image for project: 'Module Maven Archetype'
  1. Module Maven Archetype
  2. EMMA-37

ServiceImpl.getDAO should not be public

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Ready for Work
    • Priority: Should
    • Resolution: Unresolved
    • Affects Version/s: 1.1.1
    • Fix Version/s: 1.1.2
    • Complexity:
      Low

      Description

      If you choose to have the archetype create a service for you, it generates a "public XyzDAO getDao()" method in the ServiceImpl method.

      I would vote for removing this method. Alternately, it can be protected. But definitely it should not be public.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            darius Darius Jazayeri [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Time Tracking

                Estimated:
                Original Estimate - 30 minutes
                30m
                Remaining:
                Remaining Estimate - 30 minutes
                30m
                Logged:
                Time Spent - Not Specified
                Not Specified