Reminder: Create & find trunk-related issues here. Legacy Trac tickets are still available. Problems? Workflow feedback? Need a module project? Open a support ticket.

XForms Module

XForms module does not load in 1.5.x

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Keywords:
  • Description:

    In the current 1.5.x the scheduler_task_config table has had a uuid column added.

    The xforms module attempts to create scheduled tasks via sql, but it fails because uuid is required.

    -Darius

  1. 1906_XForm_UUID.patch
    (21 kB)
    Burke Mamlin
    2010-01-14 06:53:07 EST

Activity

Hide
Ben Wolfe added a comment - 2009-12-31 15:33:07 EST

Marking TRAC-1994 as a duplicate of this ticket.

Jaime, can you attach a .patch file to this ticket for Daniel to review/apply?

Show
Ben Wolfe added a comment - 2009-12-31 15:33:07 EST Marking TRAC-1994 as a duplicate of this ticket. Jaime, can you attach a .patch file to this ticket for Daniel to review/apply?
Hide
Sagar Shah added a comment - 2010-01-14 06:53:07 EST

Patch file which edits the scripts for 'scheduler_task_config' table to accomodate the column UUID

Show
Sagar Shah added a comment - 2010-01-14 06:53:07 EST Patch file which edits the scripts for 'scheduler_task_config' table to accomodate the column UUID
Hide
Ben Wolfe added a comment - 2010-01-14 19:25:13 EST

Daniel, can you review/apply this patch?

Show
Ben Wolfe added a comment - 2010-01-14 19:25:13 EST Daniel, can you review/apply this patch?
Hide
Ben Wolfe added a comment - 2010-01-15 20:12:01 EST

The xforms module will not load in openmrs 1.5 or 1.6 without this patch.

Show
Ben Wolfe added a comment - 2010-01-15 20:12:01 EST The xforms module will not load in openmrs 1.5 or 1.6 without this patch.
Hide
Daniel Kayiwa added a comment - 2010-01-18 12:47:00 EST


This patch makes the module throw exceptions for versions of openmrs lower than 1.6 which do not have the uuid column.

Show
Daniel Kayiwa added a comment - 2010-01-18 12:47:00 EST This patch makes the module throw exceptions for versions of openmrs lower than 1.6 which do not have the uuid column.
Hide
Darius Jazayeri added a comment - 2010-01-18 17:54:57 EST

Hi Daniel,

Just FYI, for the HTML Form Entry module I actually needed to have 1.4.x, 1.5.x, and 1.6.x branches, to get things to work.

Show
Darius Jazayeri added a comment - 2010-01-18 17:54:57 EST Hi Daniel, Just FYI, for the HTML Form Entry module I actually needed to have 1.4.x, 1.5.x, and 1.6.x branches, to get things to work.
Hide
Daniel Kayiwa added a comment - 2010-01-18 18:00:44 EST

Thanks Darius for sharing that what you have done with the HTML Form Entry module.

How do you compare that approach with just doing only the problematic sql statements updates in the Activator, where i would know whether we have the uuid field or not?

Show
Daniel Kayiwa added a comment - 2010-01-18 18:00:44 EST Thanks Darius for sharing that what you have done with the HTML Form Entry module. How do you compare that approach with just doing only the problematic sql statements updates in the Activator, where i would know whether we have the uuid field or not?
Hide
Darius Jazayeri added a comment - 2010-01-18 19:03:54 EST

If you're just talking about creating scheduler tasks, it makes sense to do that in the activator, yes.

(Because when they upgrade from 1.4 to 1.5 that should automatically upgrade scheduler_task_config without you having to do anything.)

Show
Darius Jazayeri added a comment - 2010-01-18 19:03:54 EST If you're just talking about creating scheduler tasks, it makes sense to do that in the activator, yes. (Because when they upgrade from 1.4 to 1.5 that should automatically upgrade scheduler_task_config without you having to do anything.)
Hide
Ben Wolfe added a comment - 2010-01-22 14:50:53 EST

You can't fix this in the activator because the module doesn't even load in 1.5. The sqldiff is run before the activator and the sqldiff is where the problem is. The uuid column is a "non-null unique" column and must be filled in when creating those rows.

Doing sql updates in the activator is not recommended anyway. The solution is to have a 1.4.x-compatible branch off of your current code in your module. Then in trunk its 1.5+ compatible, so you set the openmrs version in your config.xml to 1.5.0.

Show
Ben Wolfe added a comment - 2010-01-22 14:50:53 EST You can't fix this in the activator because the module doesn't even load in 1.5. The sqldiff is run before the activator and the sqldiff is where the problem is. The uuid column is a "non-null unique" column and must be filled in when creating those rows. Doing sql updates in the activator is not recommended anyway. The solution is to have a 1.4.x-compatible branch off of your current code in your module. Then in trunk its 1.5+ compatible, so you set the openmrs version in your config.xml to 1.5.0.
Hide
Ben Wolfe added a comment - 2010-02-02 16:50:48 EST

Marking as Needs Review so Daniel can weigh in on if he wants to create the 1.5.x-compatible branch or not.

Show
Ben Wolfe added a comment - 2010-02-02 16:50:48 EST Marking as Needs Review so Daniel can weigh in on if he wants to create the 1.5.x-compatible branch or not.
Hide
Ben Wolfe added a comment - 2010-02-02 18:06:59 EST

Great! Marking this as fixed in the 3.8.0 release of the xforms module.

Show
Ben Wolfe added a comment - 2010-02-02 18:06:59 EST Great! Marking this as fixed in the 3.8.0 release of the xforms module.

People

Dates

  • Created:
    2009-10-28 20:56:32 EDT
    Updated:
    2010-08-02 12:22:55 EDT
    Resolved:
    2010-07-01 22:45:27 EDT