Reminder: Create & find trunk-related issues here. Legacy Trac tickets are still available. Problems? Workflow feedback? Need a module project? Open a support ticket.

OpenMRS Trunk

Move tribe to person attribute

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Could Could
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: OpenMRS 1.5.0
  • Component/s: None
  • Severity:
    3
  • Keywords:
  • Description:
    Hide

    When OpenMRS started, tribe was an attribute of the patient table. Over time, we developed the person_attribute table to hold implementation-specific attributes of people. Since not all implementation need/want tribe as part of the system, person_atttribute is a better place for it. One option would be to migrate tribe to person attributes over a couple OpenMRS updates (deprecating it in one and removing in another). Then a tribe module could be created to add the tribe functionality for those implementations who want it.

    See also TRAC-624

    Show
    When OpenMRS started, tribe was an attribute of the patient table. Over time, we developed the person_attribute table to hold implementation-specific attributes of people. Since not all implementation need/want tribe as part of the system, person_atttribute is a better place for it. One option would be to migrate tribe to person attributes over a couple OpenMRS updates (deprecating it in one and removing in another). Then a tribe module could be created to add the tribe functionality for those implementations who want it. See also TRAC-624

Attachments

  1. Text File
    attribute-priv-and-tribe.patch
    (97 kB)
    Burke Mamlin
    2008-10-21 20:17:23 EDT
  2. Text File
    openmrs-652.patch
    (90 kB)
    Burke Mamlin
    2008-09-26 13:47:52 EDT

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ben Wolfe added a comment - 2008-06-06 17:08:58 EDT

Awesome, thanks for this Upul. It looks like you've found everything.

My only suggestions are for the patch are:

  1. Leave the Manage Tribes page there with a note on it saying that you should download the Tribe module and install it now.

actually, thats all for the patch.

The module needs to extend the org.openmrs.patientDashboard.Header extensionPoint and add the tribe back to the patient dashboard.

TRAC-804 will need to be fixed soon after this change for James Arbaugh's needs and the Edit Tribe Permission hack that was put in.

Show
Ben Wolfe added a comment - 2008-06-06 17:08:58 EDT Awesome, thanks for this Upul. It looks like you've found everything. My only suggestions are for the patch are:
  1. Leave the Manage Tribes page there with a note on it saying that you should download the Tribe module and install it now.
actually, thats all for the patch. The module needs to extend the org.openmrs.patientDashboard.Header extensionPoint and add the tribe back to the patient dashboard. TRAC-804 will need to be fixed soon after this change for James Arbaugh's needs and the Edit Tribe Permission hack that was put in.
Hide
Permalink
Ben Wolfe added a comment - 2008-06-27 13:17:59 EDT

I see in rev:4599 you added a note in the old location. However, I was meaning to leave a note in core code alluding to the fact that there is a module that they should use now. I think this is necessary because some people will download 1.4, see no tribes page and freak out. A text there that says "go here to download a new module, all your data will be imported..." will calm them down.

In 1.5 we can remove that link and text and just assume people will go and download the module.

Show
Ben Wolfe added a comment - 2008-06-27 13:17:59 EDT I see in rev:4599 you added a note in the old location. However, I was meaning to leave a note in core code alluding to the fact that there is a module that they should use now. I think this is necessary because some people will download 1.4, see no tribes page and freak out. A text there that says "go here to download a new module, all your data will be imported..." will calm them down. In 1.5 we can remove that link and text and just assume people will go and download the module.
Hide
Permalink
Ben Wolfe added a comment - 2008-08-14 13:57:56 EDT

The mysql diff update file needs to get rid of the old permissions:

delete from role_privilege where privilege like '%Tribes';

otherwise, the user pages and manage role pages don't work.

Show
Ben Wolfe added a comment - 2008-08-14 13:57:56 EDT The mysql diff update file needs to get rid of the old permissions: 
delete from role_privilege where privilege like '%Tribes';
otherwise, the user pages and manage role pages don't work.
Hide
Permalink
Ben Wolfe added a comment - 2008-09-26 13:45:38 EDT

On second look, the privilege doesn't really need to be deleted as long as the Manage Tribes relationship between privilege isn't deleted.

I've attached an updated patch against the latest trunk and I modified the message on the old tribe that points users at the new tribe module.

Show
Ben Wolfe added a comment - 2008-09-26 13:45:38 EDT On second look, the privilege doesn't really need to be deleted as long as the Manage Tribes relationship between privilege isn't deleted. I've attached an updated patch against the latest trunk and I modified the message on the old tribe that points users at the new tribe module.
Hide
Permalink
Ben Wolfe added a comment - 2008-10-21 20:17:23 EDT

Combined patch with Edit Person Attribute permission and Tribe removal

Show
Ben Wolfe added a comment - 2008-10-21 20:17:23 EDT Combined patch with Edit Person Attribute permission and Tribe removal
Hide
Permalink
Ben Wolfe added a comment - 2008-10-21 20:17:45 EDT

Added patch to work with latest trunk. Patch also contains some fixes from the code review session: http://openmrs.org/wiki/2008-10-21_Code_Review

Patch is combined with the one in ticket TRAC-804.

Show
Ben Wolfe added a comment - 2008-10-21 20:17:45 EDT Added patch to work with latest trunk. Patch also contains some fixes from the code review session: http://openmrs.org/wiki/2008-10-21_Code_Review Patch is combined with the one in ticket TRAC-804.
Hide
Permalink
Ben Wolfe added a comment - 2008-11-11 22:26:27 EST

Committed to trunk in rev:5974

Show
Ben Wolfe added a comment - 2008-11-11 22:26:27 EST Committed to trunk in rev:5974
Hide
Permalink
Ben Wolfe added a comment - 2008-11-26 20:08:10 EST

Fixed an issue with the Field object on forms pointing to Patient.Tribe still. See rev:6130

Show
Ben Wolfe added a comment - 2008-11-26 20:08:10 EST Fixed an issue with the Field object on forms pointing to Patient.Tribe still. See rev:6130

People

Dates

  • Created:
    2008-03-14 14:22:51 EDT
    Updated:
    2010-07-08 16:21:02 EDT
    Resolved:
    2010-07-01 22:41:18 EDT
Atlassian JIRA (v4.1.1#522) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for OpenMRS. Try JIRA - bug tracking software for your team.