Reminder: Create & find trunk-related issues here. Legacy Trac tickets are still available. Problems? Workflow feedback? Need a module project? Open a support ticket.

OpenMRS Trunk

PatientService.getPatientIdentifiers() returns voided patients

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Must Must
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: OpenMRS 1.5.0
  • Component/s: None
  • Severity:
    3
  • Keywords:
  • Description:

    This is according to Darius (via cell phone). We need to create an @should and test case to see if this the case.

Attachments

  1. File
    patient-identifiers-voided.diff
    (3 kB)
    Burke Mamlin
    2009-07-02 20:39:34 EDT

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nyoman Ribeka added a comment - 2009-07-01 13:51:23 EDT

Justin,

We want to avoid the patient identifiers that has been voided right? Patient identifiers, not the patient?

Show
Nyoman Ribeka added a comment - 2009-07-01 13:51:23 EDT Justin, We want to avoid the patient identifiers that has been voided right? Patient identifiers, not the patient?
Hide
Permalink
Justin Miranda added a comment - 2009-07-01 20:25:52 EDT

This was a bug reported by Darius, so I'll let him have the last word.

I think he meant that PatientService.getPatientIdentifiers() should return PatientIdentifiers where PatientIdentifier.getVoided() == false AND PatientIdentifier.getPatient().getVoided() == false. In other words, if a patient has been voided, we don't want to see their PatientIdentifiers.

Show
Justin Miranda added a comment - 2009-07-01 20:25:52 EDT This was a bug reported by Darius, so I'll let him have the last word. I think he meant that PatientService.getPatientIdentifiers() should return PatientIdentifiers where PatientIdentifier.getVoided() == false AND PatientIdentifier.getPatient().getVoided() == false. In other words, if a patient has been voided, we don't want to see their PatientIdentifiers.
Hide
Permalink
Darius Jazayeri added a comment - 2009-07-01 20:34:43 EDT

Yes, that's what I meant: Calls to getPatientIdentifiers() should not return identifiers that belong to voided patients.

I forget where this was causing a bug. And I forget whether the methods I was talking about was supposed to have parameters or not.

-Darius

Show
Darius Jazayeri added a comment - 2009-07-01 20:34:43 EDT Yes, that's what I meant: Calls to getPatientIdentifiers() should not return identifiers that belong to voided patients. I forget where this was causing a bug. And I forget whether the methods I was talking about was supposed to have parameters or not. -Darius
Hide
Permalink
Nyoman Ribeka added a comment - 2009-07-02 20:39:34 EDT

patch to prevent voided patients's identifiers get returned

Show
Nyoman Ribeka added a comment - 2009-07-02 20:39:34 EDT patch to prevent voided patients's identifiers get returned
Hide
Permalink
Nyoman Ribeka added a comment - 2009-07-02 20:40:00 EDT

patch added for review.

Show
Nyoman Ribeka added a comment - 2009-07-02 20:40:00 EDT patch added for review.
Hide
Permalink
Ben Wolfe added a comment - 2009-07-06 16:55:41 EDT

Fixed in trunk in rev:8916 and in 1.5.x in rev:8917

Show
Ben Wolfe added a comment - 2009-07-06 16:55:41 EDT Fixed in trunk in rev:8916 and in 1.5.x in rev:8917

People

Dates

  • Created:
    2009-05-28 22:44:24 EDT
    Updated:
    2010-07-08 16:20:52 EDT
    Resolved:
    2010-07-01 22:44:07 EDT
Atlassian JIRA (v4.1.1#522) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for OpenMRS. Try JIRA - bug tracking software for your team.