OpenMRS Trunk

Yeah, this isn't going to make it into 1.5.0, regardless of importance.

added datechanged and changed by to the encounter table

please let me know if any changes for the submitted patch

Can you use the standard liquibase element alternations instead of the <sql> tag? We want the liquibase file to be database independent and not depenedent on mysql. See http://www.liquibase.org/manual/home#available_database_refactorings or other examples of addColumn in our liquibase-update-to-latest.xml file. Thanks!

Hi madanmohan,

Do you want to make these changes? I'd like to get this into OpenMRS 1.6.

In addition to Ben's comment, a few more of mine:

• in Encounter.hbm.xml dateChanged needs to be allowed to be null
• in Encounter.java, get rid of @Element(required = false), and the import of that annotation. (We are going to stop using simpleframework for xml serialization, so there's no need to add this to a new class.)

Thanks!

-Darius (the 1.6 release manager)

Patch for this ticket

Thanks Namrata! Because this is slated for 1.6, we'll get this reviewed very soon!

Hi Namrata,

Thanks for the patch. Ben, Justin, and I reviewed it today, and we have a few comments:

• In the Encounter.hbm.xml file, the new columns say not-null="true", but it's supposed to be not-null="false"
• In liquibase-update-to-latest.xml, you also need to add a foreign key constraint on the changed_by column.
• You don't need to add anything to Encounter.java, because the changedBy and dateChanged properties are already inherited from BaseOpenmrsData.

-Darius

Hi,

Thanks for comment,

Can you please review again. I made changed according to your comment.

Looks good. I suggest we split the addColumn into two changesets when we apply it to trunk.

Committed to trunk in changeset rev:11630.