OpenMRS Trunk

er reverse ajax is the proper link

see http://getahead.org/dwr/other/upgrading/dwr20 for information on what needs to be done.

If anybody takes this on – please check the README in the lib/dwr file of the core openmrs folder of svn to see if the changes there have been applied in DWR 2.x.

I'd be in favor of 3.x, when fully released, for the following reason:

DWR 3.0 docs

To whoever ends up doing this, TRAC-955 would be a nice fix to handle as well.

Replying to [dthomas|comment:5]:
> I'd be in favor of 3.x, when fully released, for the following reason:
>
> DWR 3.0 docs
+1

Upul, think you can take this on?

are we going to wait for 3.0 or go with 2.0?
i'm currently working on it. need the reverse ajax capability

Is there a need to wait for 3.0? What must-have features will it add? Do they have a timeline for it?

Upul, did you get any work done on this? If you're ok with it, can you reassign it to nribeka?

initial patch of the upgrade. comments please.

replace the path

Changes to the dwr's util.js file

In a dwr call, does the function /have/ to be at the end now? That will break most modules if it does, because I think most calls will have the callback function as the first parameter.

I think they removed the support for first parameter since 2.0.

Taken from dwr website:

The callback-as-first-parameter system has been deprecated since version 0.9 in favor of the callback-as-last-parameter system. In version 2.0 we removed support for the first-parameter option because it caused some hard to detect bugs with null parameters. From version 2.0 the callback must be the last parameter, and can not be the first parameter.

When I read the DWR docs, it seemed like callback-as-last-parameter was the way to go, and I don't think I've ever written it as the first one. I hope that's evidence that others will have read the docs that way also.

I was not one of those. Back when I first wrote most of this it was totally optional for either end. I'm guessing there are a good number of modules that copied from trunk this way. We'll need to warn module writers that they'll need to fix their dwr callbacks.

Darius + Ben, I think we also need to warn about the other changes as well. Like DWRUtil to dwr.util and DWREngine to dwr.engine.

As for the callback, I saw some of the callback are in the last param and some other are in the first param. We use the callback as first param in the patient matching module which means we need to change it.

Would it be possible to create an alias in openmrs.js that forwards all calls to DWRUtil and DWREngine to dwr.util and dwr.engine ?

Not sure what to do about the callbacks though. Do you have an idea about how many there are?

Ben, i'm not sure the alias works. But the DWRUtil and DWREngine is only deprecated and not completely gone yet. Isn't it going to create some conflicting call?

Ok, so we don't need the alias just yet. I'll bet the move to dwr 3.0 will get rid of those deprecated methods and we'll need to fix everything.

Can you do a little research to see if there is a way to get the callbacks to still work just as they are now? I don't really want to break all the modules that are doing it the "wrong" way in a point release.

Marking as "needs review" and putting it in the 1.5 milestone. This will be reviewed in one of our weekly code reviews.

Do you want to be in on that Win?

The code changes look straight forward, thanks for doing all that Win. I'll test it out on my machine and get this into trunk as soon as possible.

I'll send out a notice to module owners on the dev list to let them know of the callback function parameter switch.

Committed to trunk in revision rev:6439. Thanks Win!

Formentry module upgraded to work with trunk in rev:6440.