Reminder: Create & find trunk-related issues here. Legacy Trac tickets are still available. Problems? Workflow feedback? Need a module project? Open a support ticket.

Logic Module

Add simple Logic Module admin page with ability to register default logic rules

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Should Should
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Severity:
    3
  • Complexity:
    Low
  • Keywords:
  • Description:
    Hide

    The logic module would benefit from a new admin page which would allow users to manually load default logic rules from concepts using the LogicUtil.registerDefaultRules() method. This method can take several minutes to complete so this should be run in a separate thread with appropriate feedback (e.g. indicating that the process is running and not hung) provided to the user. As additional reference, please see this thread http://n2.nabble.com/OpenMRS-1-6-Beta-released-td4484824.html#a4484824.

    Show
    The logic module would benefit from a new admin page which would allow users to manually load default logic rules from concepts using the LogicUtil.registerDefaultRules() method. This method can take several minutes to complete so this should be run in a separate thread with appropriate feedback (e.g. indicating that the process is running and not hung) provided to the user. As additional reference, please see this thread http://n2.nabble.com/OpenMRS-1-6-Beta-released-td4484824.html#a4484824.

Attachments

  1. Text File
    flushSession.patch
    (2 kB)
    Burke Mamlin
    2010-03-08 17:19:35 EST
  2. Text File
    isAnswerOnly.patch
    (3 kB)
    Burke Mamlin
    2010-03-08 17:13:43 EST
  3. Text File
    logicUtil-dj-edits.patch
    (8 kB)
    Burke Mamlin
    2010-03-08 18:04:35 EST
  4. Text File
    patch2079.txt
    (15 kB)
    Burke Mamlin
    2010-02-12 15:04:22 EST

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Darius Jazayeri added a comment - 2010-02-11 15:34:33 EST

This is not strictly required for 1.6 release. It could go in a followup release of the logic module. (But it would be preferable to have it in 1.6.)

Show
Darius Jazayeri added a comment - 2010-02-11 15:34:33 EST This is not strictly required for 1.6 release. It could go in a followup release of the logic module. (But it would be preferable to have it in 1.6.)
Hide
Permalink
Stephen Lorenz added a comment - 2010-02-11 17:03:29 EST

I believe this is nearly complete. I am waiting to resolve an issue with Ticket 2052 http://dev.openmrs.org/ticket/2052 to make sure I am calling the LogicUtil.registerDefaultRules() method the right way.

Show
Stephen Lorenz added a comment - 2010-02-11 17:03:29 EST I believe this is nearly complete. I am waiting to resolve an issue with Ticket 2052 http://dev.openmrs.org/ticket/2052 to make sure I am calling the LogicUtil.registerDefaultRules() method the right way.
Hide
Permalink
Stephen Lorenz added a comment - 2010-02-12 15:04:03 EST

The patch is ready for review.

Show
Stephen Lorenz added a comment - 2010-02-12 15:04:03 EST The patch is ready for review.
Hide
Permalink
Ben Wolfe added a comment - 2010-02-18 22:18:04 EST

This patch looks good. We'll apply this as the same time as TRAC-2052 and release logic 0.3.

Show
Ben Wolfe added a comment - 2010-02-18 22:18:04 EST This patch looks good. We'll apply this as the same time as TRAC-2052 and release logic 0.3.
Hide
Permalink
Darius Jazayeri added a comment - 2010-03-08 17:13:22 EST

I want to make a couple changes to this:

  • I'm going to add a json.jar to core, and have this module call that, instead of needing to provide its own json
  • Explicitly show the GP that controls what datatypes get loaded (via the GP portlet?)
  • Change registerDefaultTokens() to skip N/A concepts. (This requires a patch to core, which I'm attaching here.)
Show
Darius Jazayeri added a comment - 2010-03-08 17:13:22 EST I want to make a couple changes to this:
  • I'm going to add a json.jar to core, and have this module call that, instead of needing to provide its own json
  • Explicitly show the GP that controls what datatypes get loaded (via the GP portlet?)
  • Change registerDefaultTokens() to skip N/A concepts. (This requires a patch to core, which I'm attaching here.)
Hide
Permalink
Darius Jazayeri added a comment - 2010-03-08 17:13:43 EST

patch for core

Show
Darius Jazayeri added a comment - 2010-03-08 17:13:43 EST patch for core
Hide
Permalink
Darius Jazayeri added a comment - 2010-03-08 17:19:55 EST

Also, I want to have registerDefaultRules periodically flush its changes to the database, to avoid the hibernate session getting full, and things slowing down.

That patch is also attached.

Show
Darius Jazayeri added a comment - 2010-03-08 17:19:55 EST Also, I want to have registerDefaultRules periodically flush its changes to the database, to avoid the hibernate session getting full, and things slowing down. That patch is also attached.
Hide
Permalink
Darius Jazayeri added a comment - 2010-03-08 18:04:16 EST

Finally, here are my edits to slorenz's patch

Show
Darius Jazayeri added a comment - 2010-03-08 18:04:16 EST Finally, here are my edits to slorenz's patch
Hide
Permalink
Darius Jazayeri added a comment - 2010-03-10 02:05:01 EST

Fixed in rev:12368 which will be logic module 0.4

Show
Darius Jazayeri added a comment - 2010-03-10 02:05:01 EST Fixed in rev:12368 which will be logic module 0.4

People

Dates

  • Created:
    2010-02-09 02:40:20 EST
    Updated:
    2010-07-29 09:40:28 EDT
    Resolved:
    2010-07-01 22:46:09 EDT
Atlassian JIRA (v4.1.1#522) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for OpenMRS. Try JIRA - bug tracking software for your team.